melcloud: Don't optimistically update local state - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_device_propertycalled the MELCloud cloud API and then immediately cached the requested value into_properties_cache, which is exactly whatget_device_property()(used by every port'sread_value()) returns. No confirmation that the physical device actually applied the change.1bc98a9.POLL_AFTER_WRITE = TrueonMELCloud, so a real device refresh (_update_devices()) runs immediately after every write instead of relying on an assumed value.DEFAULT_POLL_INTERVALis otherwise inherited as 1800s, so without this the port could show a false "applied" value for up to 30 minutes.Test plan
ruff check/ruff format --checkpass (verified locally)