Package: Update @vscode/test-electron to 3.1.0 & qt-qml: Declare DataStream._data explicitly as Buffer - #539
Merged
OrkunTokdemir merged 3 commits intoAug 3, 2026
Conversation
OrkunTokdemir
commented
Aug 3, 2026
OrkunTokdemir
commented
Collaborator
- Package: Update @vscode/test-electron to 3.1.0
- qt-qml: Declare DataStream._data explicitly as Buffer
VS Code 1.110+ renamed the macOS app binary from Contents/MacOS/Electron to Contents/MacOS/Code, so test-electron 2.x fails to launch the test instance with spawn ENOENT. Version 3.1.0 handles the new name. Its typings use generic Buffer, so typescript and @types/node are refreshed in the lockfiles within their existing ranges.
With @types/node 20.19+ and tsc 5.7+, Buffer.alloc(0) is inferred as the narrower Buffer<ArrayBuffer>, which no longer accepts the plain Buffer passed to the data setter. An explicit annotation keeps the field at the wide Buffer type. No runtime change.
benchoq
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.