Introduce sms-api & qt-sms - #442
Draft
OrkunTokdemir wants to merge 130 commits into
Draft
Conversation
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
from
March 16, 2026 16:17
090c53f to
4d27dd8
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
3 times, most recently
from
April 8, 2026 13:29
41d9cd4 to
1e8b129
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
from
April 10, 2026 17:01
9eb50c7 to
3390a3a
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
3 times, most recently
from
April 22, 2026 08:20
45ca481 to
576afe3
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
2 times, most recently
from
May 8, 2026 14:47
b15546d to
51b0acc
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
3 times, most recently
from
June 1, 2026 11:26
d895bee to
f0f8012
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
2 times, most recently
from
June 5, 2026 15:47
0ad368d to
7c07a83
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
7 times, most recently
from
June 24, 2026 14:53
e6706ad to
1cf6fe4
Compare
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
3 times, most recently
from
June 25, 2026 14:49
a1f37e2 to
21bc761
Compare
The Get Started walkthrough panel used the default webview placeholder icon in its editor tab, unlike the Qt Welcome page. Set the panel's iconPath to the themed dark/light Qt icons so both pages look consistent. The icon is applied in wirePanel, so it also survives a window reload (serializer path).
The walkthrough's "Get latest Qt Framework" button was disabled whenever any Qt version was installed on disk, so users with an outdated Qt could not grab the newest release. Disable it only when the newest available version is actually installed. Determining "latest" requires the remote available-packages list, so it is resolved asynchronously and cached. To avoid spawning the service or showing progress UI just to compute a button state, the check only runs when a session is already connected; otherwise the result is treated as unknown and the button stays enabled (the safe direction). The state is refreshed when the panel opens and after an install completes.
Show the installed package's version alongside its name in the "Successfully installed" notification.
Pin the walkthrough app to the viewport height (height: 100vh) instead of min-height so overflow-y has a fixed box to clip against, showing an internal scrollbar when the content is taller than the screen.
Replace the remote allowlist fetch with a simple check that the Qt Account email ends with @qt.io, dropping the network round-trip and the allowlist file dependency.
OrkunTokdemir
marked this pull request as ready for review
July 17, 2026 11:39
OrkunTokdemir
marked this pull request as draft
July 17, 2026 11:39
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
from
July 17, 2026 14:05
53dd69e to
ed86130
Compare
When commands are run separately, instead of running `npm run all_dev:x`, vite is not installed properly in qt-sm. To fix this, we need to use `npm run install:all` for qt-sm.
- Add a right-aligned "Reset password" button to the sign-in step, backed by a new qt-sm.resetPassword command that opens https://login.qt.io/forgot - Hide "Reset walkthrough" when there is no progress to reset - Hide "Mark Done" once the walkthrough is marked done - Remove a stray statement after a console.debug call
- Prefill the email prompt with the last attempted address so a retry after a failed attempt starts from it - Show a readable message for invalid credentials instead of the raw server response, with a "Reset Password" action in the notification - Show login failures once instead of twice (createSession and the login command both raised a notification for the same error)
`sms-api` was never installed by the `install:all` chains, so its dependencies resolved to stale hoisted copies in the root `node_modules`, which broke `vsce` packaging for `qt-sm` with `ELSPROBLEMS`. Also add sms-api steps to the `build-linux.yml` workflow, so that it is built.
OrkunTokdemir
force-pushed
the
orkun_sms_api_12_03_2026
branch
from
July 21, 2026 08:36
ee6e51e to
b253aba
Compare
When signed out, the step offers Sign In, Create Account and Forgot Password. When signed in, it shows the account email and a Sign Out button. Signing out flips the step back to sign-in.
Welcome views cannot center text, so the "or" between the buttons was stuck on the left. The webview matches the design: Sign In, Forgot Password, "or", Create Account. Its styling copies the native welcome view so both sections look the same.
Lists the Qt versions found on disk, between Get Started and Qt Account. Each version has a trash button that asks for confirmation, deletes the version folder and unregisters its qtpaths from qt-core. "Install other versions" opens the package picker. The view only shows while something is installed. Removal deletes the folder directly for now because the service does not implement packages/remove yet.
The first-app step and the done flag used to survive a test reset. Clear them and re-render the panel, so the walkthrough starts again from step 1. The webview Reset link now shares the same code path.
Continue stays disabled until "I have read these and accept the license agreements" is ticked. The checkbox and the buttons can be reached with the arrow keys, and Enter toggles the checkbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.