[5192][ADD] openai_connector, product_name_generator by nobuQuartile · Pull Request #161 · qrtl/rmm-custom

nobuQuartile · 2025-06-09T08:26:41Z

AungKoKoLin1997 · 2025-06-16T06:08:07Z

@nobuQuartile Please test the product_name_generator module. I tried to add the button in the footer of extra product media view but there is a issue when I used the js code. So, I just add in the header at the moment.

AungKoKoLin1997

Partial Review.

AungKoKoLin1997 · 2025-06-17T02:33:04Z

Can you please create new PR to run the pre-commit?
So, this file will not include in this PR.

I have rebased this branch.

AungKoKoLin1997 · 2025-06-17T02:53:12Z

+        api_key = self.env.company.openai_api_key
+        if not api_key:
+            raise UserError(_("OpenAI API key is not configured"))
+        client = OpenAI(api_key=api_key)


Is this correct variable name?

I changed it to openai_client.
Is this good? How do you feel?

nobuQuartile · 2025-06-18T07:01:46Z

@AungKoKoLin1997
I have updated what you reviewed. Could you please continue reviewing this PR?

AungKoKoLin1997 · 2025-06-30T03:22:43Z

@nobuQuartile Is this PR ready to review?

AungKoKoLin1997 · 2025-07-03T05:06:03Z

@nobuQuartile Please review my last commit. I make some adjustments for openai_connector. Please update the readme with clear information and better to add USAGE.md with the instruction of how to use this module from another modules.
Now, the functionality of product_name_generator is working.

yostashiro

Partial review.

yostashiro · 2025-07-04T14:33:59Z

The file name should be xxx_views.xml.

Indentation should be fixed. Same for other .xml files.

AungKoKoLin1997 · 2025-07-07T02:23:19Z

I feel like using image_url is not a good practice. If we want to use this module for another project or later this project doesn't use website module anymore, this module will not be worked. But as per nobu research, we can't use binary data because of large data than openai can accept. So, we just forget above points for now.

AungKoKoLin1997 · 2025-07-17T04:23:58Z

@nobuQuartile Check the latest changes and test it.
I think the readme of openai connector is not good enough especially CONFIGURE.md.
Please improve it when you have time.

nobuQuartile · 2025-07-17T06:25:36Z

@AungKoKoLin1997
Could you create the data of base_api_connection in openai_connecter?

AungKoKoLin1997 · 2025-07-17T07:07:04Z

Could you create the data of base_api_connection in openai_connecter?

I don't think that is needed. It is described in the CONFIGURE.md

nobuQuartile · 2025-07-17T10:20:37Z

I think the error will be fixed after the base_api_connection's PR is merged and this branch is rebased.

AungKoKoLin1997 · 2025-09-18T06:21:45Z

@nobuQuartile Please check my last commit.

nobuQuartile · 2025-09-18T06:23:45Z

@nobuQuartile Please check my last commit.
Good. Thank you.

yostashiro

Just some style adjustments. Otherwise, LGTM.

nobuQuartile · 2025-09-25T06:15:17Z

I have force-pushed to solve the pre-commit error.

nobuQuartile · 2025-10-02T08:49:58Z

I did the functional test in the test env.
We can merge this PR after verifying that the PR test error does not occur once the related PR is merged.

nobuQuartile · 2025-10-08T06:35:39Z

Could you merge this PR?
I just wanted to let you know that I'll do this today.

nobuQuartile · 2025-10-08T06:37:07Z

Sorry, this one should be merged after the base_api_connector and rebase this branch.

nobuQuartile · 2025-10-08T06:49:14Z

@AungKoKoLin1997
Do you know why "test with OCB" has an error?

AungKoKoLin1997 · 2025-10-08T06:57:43Z

@AungKoKoLin1997 Do you know why "test with OCB" has an error?

@nobuQuartile Please add base_api_connection in text-requirements.txt.

nobuQuartile · 2025-10-08T07:37:57Z

@AungKoKoLin1997
Could you fix the pre-commit error?
I did pre-commit in my env, but it does not fix the error.

AungKoKoLin1997 · 2025-10-08T07:47:45Z

@AungKoKoLin1997 Could you fix the pre-commit error? I did pre-commit in my env, but it does not fix the error.

I don't see there is a pre-commit issue in the CIs.
What do you want me to fix?

nobuQuartile · 2025-10-08T08:00:34Z

Please forget that, Sorry.

nobuQuartile · 2025-10-08T08:00:58Z

Ready to merge

nobuQuartile force-pushed the 5192-add-openai_connecter branch from f1b788c to 4b7b5fa Compare June 9, 2025 08:35

nobuQuartile changed the title ~~[5192][ADD] openai_connecter~~ [5192][ADD] openai_connector Jun 9, 2025

nobuQuartile marked this pull request as draft June 9, 2025 08:52

nobuQuartile force-pushed the 5192-add-openai_connecter branch from 4b7b5fa to 8ff032c Compare June 9, 2025 09:15

nobuQuartile changed the title ~~[5192][ADD] openai_connector~~ [5192][ADD] openai_connector, product_name_creater Jun 11, 2025

nobuQuartile requested a review from AungKoKoLin1997 June 13, 2025 08:35

nobuQuartile commented Jun 16, 2025

View reviewed changes

Comment thread product_name_generator/models/product_image.py Outdated

nobuQuartile changed the title ~~[5192][ADD] openai_connector, product_name_creater~~ [5192][ADD] openai_connector, product_name_generator Jun 16, 2025

AungKoKoLin1997 reviewed Jun 17, 2025

View reviewed changes

nobuQuartile force-pushed the 5192-add-openai_connecter branch from 84cc478 to 7142490 Compare June 18, 2025 06:34

nobuQuartile requested a review from AungKoKoLin1997 June 18, 2025 06:34

AungKoKoLin1997 reviewed Jun 19, 2025

View reviewed changes

kanda999 reviewed Jul 4, 2025

View reviewed changes

Comment thread product_name_generator/models/product_template.py

yostashiro reviewed Jul 4, 2025

View reviewed changes

nobuQuartile force-pushed the 5192-add-openai_connecter branch from db72266 to 2735665 Compare July 7, 2025 02:57

AungKoKoLin1997 force-pushed the 5192-add-openai_connecter branch from 2735665 to f6aacf8 Compare July 7, 2025 03:08

AungKoKoLin1997 force-pushed the 5192-add-openai_connecter branch from 3435850 to 292a5db Compare July 17, 2025 04:22

AungKoKoLin1997 reviewed Jul 17, 2025

View reviewed changes

Comment thread openai_connector/readme/CONFIGURE.md Outdated

Comment thread product_name_generator/models/product_template.py Outdated

nobuQuartile force-pushed the 5192-add-openai_connecter branch from 8129a5d to 3e9bcaa Compare July 17, 2025 10:15

nobuQuartile requested review from AungKoKoLin1997 and yostashiro July 17, 2025 10:20

AungKoKoLin1997 reviewed Sep 17, 2025

View reviewed changes

Comment thread openai_connector/models/openai_vision_session.py Outdated

nobuQuartile and others added 2 commits September 18, 2025 02:53

upd endpoint

22b2d95

imp

e7ec5a4

AungKoKoLin1997 approved these changes Sep 18, 2025

View reviewed changes

nobuQuartile requested review from yostashiro and removed request for yostashiro September 18, 2025 06:24

yostashiro approved these changes Sep 20, 2025

View reviewed changes

Comment thread product_name_generator/data/ir_config_parameter.xml Outdated

Comment thread product_name_generator/models/product_template.py Outdated

upd

f389c82

nobuQuartile force-pushed the 5192-add-openai_connecter branch from 8b437a1 to f389c82 Compare September 25, 2025 05:59

nobuQuartile added 2 commits October 8, 2025 06:41

[test

9f954b8

upd test 2

1f9d695

upd

1dea9ee

nobuQuartile force-pushed the 5192-add-openai_connecter branch 3 times, most recently from a39d971 to a6c53cc Compare October 8, 2025 07:35

upd test-requirement

234b43a

nobuQuartile force-pushed the 5192-add-openai_connecter branch from a6c53cc to 234b43a Compare October 8, 2025 07:37

yostashiro merged commit bc23a3b into 15.0 Oct 8, 2025
2 checks passed

Uh oh!

Conversation

nobuQuartile commented Jun 9, 2025

Uh oh!

AungKoKoLin1997 commented Jun 16, 2025

Uh oh!

Uh oh!

AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

nobuQuartile Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

nobuQuartile Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AungKoKoLin1997 Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

nobuQuartile Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nobuQuartile commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AungKoKoLin1997 commented Jun 30, 2025

Uh oh!

AungKoKoLin1997 commented Jul 3, 2025

Uh oh!

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yostashiro Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AungKoKoLin1997 commented Jul 7, 2025

Uh oh!

AungKoKoLin1997 commented Jul 17, 2025

Uh oh!

nobuQuartile commented Jul 17, 2025

Uh oh!

AungKoKoLin1997 commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

nobuQuartile commented Jul 17, 2025

Uh oh!

Uh oh!

AungKoKoLin1997 commented Sep 18, 2025

Uh oh!

nobuQuartile commented Sep 18, 2025

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nobuQuartile commented Sep 25, 2025

nobuQuartile commented Oct 2, 2025 •

edited

Loading