[ADD] openupgradelib to 16/18/19 requirements - #83
Merged
Conversation
OCA migration scripts import openupgradelib (openupgrade.migrate, rename_fields and friends) but almost never declare it in external_dependencies, so Odoo's dependency check cannot catch it. The failure surfaces as an ImportError part-way through a module upgrade. A survey of the aggregated customer repos found it imported by migration scripts in 9 of ~11 active projects (asx, axls, fal, hls12, ocj, rbkk, rmm, sfa, thc) across ~16 modules; base_tier_validation alone spans three customers. Exactly one manifest in the whole workspace declares it, and that module sits under a .void/ directory. It is upgrade machinery rather than any customer's business logic, so it belongs in the base image next to git-aggregator rather than in each per-customer requirements file. Left unpinned, consistent with the rest of the file. Verified to install on all three bases (Python 3.10.20 / 3.10.20 / 3.12.13). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OCA migration scripts import
openupgradelib(openupgrade.migrate,rename_fields, …) but almost never declare it inexternal_dependencies, so Odoo's dependency check cannot catch it. The failure surfaces as anImportErrorpart-way through a module upgrade.Why the base rather than per-customer
A survey of the aggregated repos on the dev server found it imported by migration scripts in the large majority of active projects, spanning many modules — and declared in exactly one manifest, which sits under a
.void/directory.It is upgrade machinery rather than any project's business logic, so it belongs next to
git-aggregatorin the base rather than being repeated in each per-project requirements file (and missed in one).Notes
2026-08-05T08:10:55andOCA/openupgradelibmaster was last pushed at2026-08-05T08:10:26— 29 seconds apart, with five releases since June, so there is no staleness to route around.pip install openupgradelibsucceeds on all three current bases (Python 3.10.20 / 3.10.20 / 3.12.13), resolving to 3.13.6.masteris touched. The legacy per-version branches (10.0,15.0,17.0) still carry the old single-Dockerfilelayout and would each need the same change.