Skip to content

[6819][ADD] survey_xlsx - #124

Merged
yostashiro merged 4 commits into
15.0from
6819-add-survey_xlsx
Jul 28, 2026
Merged

[6819][ADD] survey_xlsx#124
yostashiro merged 4 commits into
15.0from
6819-add-survey_xlsx

Conversation

@smorita7749

Copy link
Copy Markdown
Contributor

@nobuQuartile

Copy link
Copy Markdown
Contributor

@smorita7749
Could you do the functional test in the copy?
You updated the requirements.txt, so you have to install these Python libraries.
You also have to update this file.(My opinion)
Docker's requirements.txt: https://github.com/qrtl/mi7-odoo/blob/15.0/requirements.txt

@smorita7749

Copy link
Copy Markdown
Contributor Author

In the first place, the libraries have already been listed on Odoo, so no need to edit requirements.txt
https://github.com/odoo/odoo/blob/15.0/requirements.txt

@smorita7749
smorita7749 force-pushed the 6819-add-survey_xlsx branch from 6eb64b3 to 12c6527 Compare July 27, 2026 02:22
@smorita7749

Copy link
Copy Markdown
Contributor Author

In the first place, the libraries have already been listed on Odoo, so no need to edit requirements.txt https://github.com/odoo/odoo/blob/15.0/requirements.txt

requirements.txt was edited by pre-commit.

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobuQuartile

Copy link
Copy Markdown
Contributor

@smorita7749
Maybe you should delete the Python library from the manifest.

@smorita7749
smorita7749 force-pushed the 6819-add-survey_xlsx branch from 9f3dae8 to eac9067 Compare July 27, 2026 09:43
@smorita7749

Copy link
Copy Markdown
Contributor Author

@smorita7749 Maybe you should delete the Python library from the manifest.

Done!

@smorita7749
smorita7749 requested a review from nobuQuartile July 28, 2026 02:37
@yostashiro
yostashiro merged commit 236a06b into 15.0 Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants