Skip to content

[6730][FIX] sale_automatic_workflow: use _get_eval_domain() to support datetime in filter - #163

Merged
yostashiro merged 2 commits into
18.0from
6730-imp-sale_automatic_workflow
Jun 29, 2026
Merged

[6730][FIX] sale_automatic_workflow: use _get_eval_domain() to support datetime in filter#163
yostashiro merged 2 commits into
18.0from
6730-imp-sale_automatic_workflow

Conversation

@nobuQuartile

@nobuQuartile nobuQuartile commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@nobuQuartile

nobuQuartile commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@AungKoKoLin1997
Could you check the error?
It seems from sale_automatic_workflow_job.
But, we do not install sale_automatic_workflow_job in hls-oca.

@AungKoKoLin1997

AungKoKoLin1997 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

But, we do not install sale_automatic_workflow_job in hls-oca.

@nobuQuartile The error is coming from sale_automatic_workflow itself.
Please make that module is reflected with latest OCA code. I found property_payment_journal_id from sale workflow process is used in your PR but that field is not exit in hls-oca code.

https://github.com/OCA/sale-workflow/blob/4085cfdcc8b4d13ac24013a0b2182fe1a9a7062d/sale_automatic_workflow/models/sale_workflow_process.py#L76-L81

@nobuQuartile
nobuQuartile force-pushed the 6730-imp-sale_automatic_workflow branch from 4a582d7 to aac77d6 Compare June 25, 2026 08:33
@nobuQuartile

nobuQuartile commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@AungKoKoLin1997
That's my fault. Sorry.

@nobuQuartile
nobuQuartile force-pushed the 6730-imp-sale_automatic_workflow branch from aac77d6 to 48f1388 Compare June 25, 2026 08:35
@yostashiro

yostashiro commented Jun 25, 2026

Copy link
Copy Markdown
Member

@AungKoKoLin1997 Can you please help add tests.

@nobuQuartile
nobuQuartile force-pushed the 6730-imp-sale_automatic_workflow branch from ea70386 to d085713 Compare June 29, 2026 04:15
@nobuQuartile
nobuQuartile force-pushed the 6730-imp-sale_automatic_workflow branch from d085713 to 8a5b79a Compare June 29, 2026 04:19
@yostashiro
yostashiro merged commit c6e3496 into 18.0 Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yostashiro yostashiro yostashiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nobuQuartile @AungKoKoLin1997 @yostashiro