[7013][IMP] stock_view_adj: merge stock_valuation_layer_view_adjust - #152
Merged
Merged
Conversation
nobuQuartile
force-pushed
the
7013-imp-stock_valuation_layer_view_adjust
branch
from
July 14, 2026 04:48
7f2bb01 to
f4f4b5a
Compare
yostashiro
approved these changes
Jul 14, 2026
yostashiro
left a comment
yostashiro
left a comment
Member
There was a problem hiding this comment.
LG, but I wonder why we created this module instead of updating stock_view_adj. Please consider merging the modules at some point.
Contributor
Author
|
stock_valuation_layer_view_adjust depens on stock_account. I think this is one of the reason. |
Member
|
I'd rather have stock_view_adj depend on stock_account then. |
nobuQuartile
changed the title
nobuQuartile
force-pushed
the
7013-imp-stock_valuation_layer_view_adjust
branch
2 times, most recently
from
July 27, 2026 06:15
4c70d84 to
a07a0f9
Compare
Integrate the stock valuation layer (SVL) view adjustments (remaining_qty and remaining_value) from stock_valuation_layer_view_adjust into stock_view_adj, and add the description field to the SVL list view. Make the module depend on stock_account. The original stock_valuation_layer_view_adjust module is moved to .void.
Contributor
Author
|
@yostashiro
I have done it. |
nobuQuartile
force-pushed
the
7013-imp-stock_valuation_layer_view_adjust
branch
from
July 27, 2026 06:21
a07a0f9 to
447e476
Compare
yostashiro
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display the valuation layer description in the tree view (after reference) so users can see it without opening the form.
QT7013