WIP: use desktop components to serve static page - #589
Open
ramfox wants to merge 4 commits into
Open
Conversation
ramfox
force-pushed
the
feat_webapp
branch
2 times, most recently
from
September 5, 2020 00:48
10fc293 to
92481cc
Compare
note: had to create a `index_dev.html` and add "unsafe-eval" to the "Content-Security-Policy" in order to quickly get to development. If we continue to work on this webapp, we should research if there is a better way to manage this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes are all in the
webappfolder, including thedistfrom webpack.Outside of the
webappfolder, there is a newwebpack.config.webapp.js, which only covers production mode.To build run
yarn build-webapp, against dist files areI'm using
serveto serve the files:serve -s app/webapp/dist, but I've also just looked at them by opening theapp/webapp/dist/index.htmlfile in my chrome browserAny other changes outside of these files is to account for "electron" or "web" mode in the quickest way possible.
To use this webapp:
http://localhost:3000, (webpack dev server defaults to3000, change that in thewebpack.config.webapp.dev.jsfile if you need it to be different)To use in dev mode:
yarn dev-webappTo use in prod mode:
yarn build-webappserve -s app/webapp/dist -l 3000