-
Notifications
You must be signed in to change notification settings - Fork 20
Added fallbacks logic for nocodes #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
44ac03e
Added fallbacks logic for nocodes
actions-user 44ab549
Fixed warnings
actions-user bcb03b5
Updaetd baseline
actions-user f174fc8
Added tests
actions-user d4b04b9
Added review fixes
actions-user 3584412
Added review fixes
actions-user bdc5df1
Added review fixes #2
actions-user f27b9b2
Apply suggestions from code review
suriksarkisyan b80ad6f
Merge branch 'develop' into feature/nocodesFallback
suriksarkisyan 04ba129
Review fixes
actions-user 2273109
Review fixes #2
actions-user 56cd194
Removed unused func
actions-user 9191771
Removed unused import
actions-user 516a7b2
Removed useless tests
actions-user File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
nocodes/src/main/java/io/qonversion/nocodes/internal/common/FallbackConstants.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package io.qonversion.nocodes.internal.common | ||
|
|
||
| object FallbackConstants { | ||
| const val DEFAULT_FILE_NAME = "nocodes_fallbacks.json" | ||
| } |
6 changes: 6 additions & 0 deletions
6
nocodes/src/main/java/io/qonversion/nocodes/internal/common/TimeoutConstants.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package io.qonversion.nocodes.internal.common | ||
|
|
||
| object TimeoutConstants { | ||
| const val FALLBACK_AVAILABLE_TIMEOUT = 5_000L | ||
| const val DEFAULT_TIMEOUT = 20_000L | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
nocodes/src/main/java/io/qonversion/nocodes/internal/di/services/ServicesAssembly.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| package io.qonversion.nocodes.internal.di.services | ||
|
|
||
| import io.qonversion.nocodes.internal.screen.service.FallbackService | ||
| import io.qonversion.nocodes.internal.screen.service.ScreenService | ||
|
|
||
| internal interface ServicesAssembly { | ||
|
|
||
| fun screenService(): ScreenService | ||
|
|
||
| fun fallbackService(): FallbackService? | ||
| } |
23 changes: 22 additions & 1 deletion
23
nocodes/src/main/java/io/qonversion/nocodes/internal/di/services/ServicesAssemblyImpl.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.