fix: mention tfvc.adoBaseUrl in "not configured" messages - #36
Merged
Conversation
On-prem users with adoBaseUrl + adoProject + PAT set were told to configure tfvc.adoOrg — a field they don't need. The underlying config check has always accepted either adoOrg (cloud) or adoBaseUrl (on-prem), but both the SCM error toast and the review-diff placeholder text only mentioned adoOrg. Update the copy to reflect what the check actually requires. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adoBaseUrl+adoProject+ PAT set were told to configuretfvc.adoOrg— a field they don't need.initRestClient()check atsrc/extension.ts:95has always acceptedadoOrg || adoBaseUrl, but both the SCM error toast and the review-diff placeholder text only mentionedadoOrg.src/extension.ts:171andsrc/providers/fileContent.ts:35to reflect what the check actually requires.Spotted in the wild: a user had valid on-prem settings (
adoBaseUrl=https://tfs.ieq-network.de,adoCollectionPath=/tfs/ieQ,adoProject=Basis Onlineshop) and was still getting the "configure tfvc.adoOrg" toast because they hadn't set the PAT yet — but the error pointed them at the wrong field.Test plan
npm run compilepassesnpm test— all 244 unit tests pass; existingnotConfigured.test.tsassertions (/not configured/i,/set pat/i,/adoproject/i) still match the new copy🤖 Generated with Claude Code