test(e2e): cover tfvc.setPat command branches - #34
Merged
Conversation
The three branches — cancel / store / clear — were uncovered. A refactor that conflated them (e.g. showed "stored" when actually clearing) would ship to users. Catch that by executing each branch with the input-box stubbed to return undefined / a value / empty string, and asserting which toast fires. Can't read the secret store directly from tests (ExtensionContext isn't exposed to test code), so the assertions target user-visible behaviour. A suiteTeardown clears the secret afterwards so the test profile doesn't inherit a stored PAT between runs. e2e count: 16 → 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tfvc.setPathad three uncovered branches: cancel (undefined), store (value), clear (empty string). A refactor that conflated them — showing "stored" when actually clearing, for instance — would ship silently.showInputBoxstubbed and asserting which toast fires. One regression test verifies stored/removed messages are distinct.suiteTeardownclears the secret between runs.Test plan
npm run test:e2e— 20 passing (was 16)🤖 Generated with Claude Code