fix: harden search_tasks against non-dict rows (v0.3.2) - #12
Merged
Merged
Conversation
Addresses the review on #9. The unparseable-row skip path called `raw.get("id")` assuming `raw` was a dict — but a non-dict row (e.g. a stray null) makes `resolve_task(raw)` raise AttributeError (not ValidationError), so it wasn't even caught: the intended "skip one bad row" became a whole-page crash. Now non-dict rows are skipped up front, and iteration tolerates a null `tasks` value. Tests for both, plus a positive status-enum equality assertion (test nit from the review). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![peqy[bot]](https://avatars.githubusercontent.com/in/1930020?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the automated review on #9.
The unparseable-row skip path in
search_tasks()calledraw.get("id")assumingrawwas a dict. But a non-dict row (a straynull) makesresolve_task(raw)raiseAttributeError, notValidationError— so it wasn't caught at all, and the intended "skip one bad row" became a whole-page crash.Fix
resolve_task), with a warning.tasksvalue (result.get("tasks") or []).None, a string) are skipped; nulltasksyields an empty page.status == TaskStatus.SCHEDULEDequality check alongside the inequality one.ruff✓ ·ruff format --check✓ ·pyright src/0 errors ✓ ·pytest181 passed ✓🤖 Generated with Claude Code