refactor: type update_opportunity_roles payload as list[RoleAssignment] (v0.3.1) - #11
Merged
Merged
Conversation
…t] (v0.3.1) Addresses the review on #10: `roles: list[dict]` was loose and gave callers no type checking/autocomplete. Introduce a `RoleAssignment` TypedDict (required contact_id; optional opportunity_contact_role_type_id, is_primary) and use it in the signature. Exported from the package root. Non-breaking — plain dicts still satisfy it structurally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![peqy[bot]](https://avatars.githubusercontent.com/in/1930020?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the automated review on #10.
update_opportunity_roles(opportunity_id, roles)typedrolesas the looselist[dict], which hurt pyright/autocomplete. This introduces aRoleAssignmentTypedDict— requiredcontact_id, optionalopportunity_contact_role_type_id/is_primary— and uses it in the signature. Exported from the package root.Non-breaking: plain dicts still satisfy the TypedDict structurally, so
apollo-cli(which passes dicts) is unaffected.ruff check✓ ·ruff format --check✓ ·pyright src/0 errors ✓ ·pytest179 passed ✓🤖 Generated with Claude Code