Skip to content

Gh775 review - #2

Open
maresb wants to merge 12 commits into
qmarcou:kill_dev_switchfrom
maresb:gh775-review
Open

Gh775 review#2
maresb wants to merge 12 commits into
qmarcou:kill_dev_switchfrom
maresb:gh775-review

Conversation

@maresb

@maresb maresb commented Feb 23, 2025

Copy link
Copy Markdown

@qmarcou

qmarcou commented Mar 7, 2025

Copy link
Copy Markdown
Owner

Shouldn't we raise a DeprecationWarning or FutureWarning instead of the default UserWarning raised by warn?

@qmarcou

qmarcou commented Mar 7, 2025

Copy link
Copy Markdown
Owner

The test_generate_pixi_toml test seems to use one of the --dev switches, triggering an extra warning compared to expected and subsequent test failure

@maresb

maresb commented Mar 7, 2025

Copy link
Copy Markdown
Author

Thanks so much @qmarcou for giving my commits a careful look! I think you're right about the UserWarning. I'll try to look into that and the --dev issue soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants