Skip to content

review: bump py3.14.3 and pysudoer 0.0.3#25

Merged
qlrd merged 1 commit into
chore/bump-py3143from
chore/bump-py3143-review
Mar 26, 2026
Merged

review: bump py3.14.3 and pysudoer 0.0.3#25
qlrd merged 1 commit into
chore/bump-py3143from
chore/bump-py3143-review

Conversation

@qlrd

@qlrd qlrd commented Mar 26, 2026

Copy link
Copy Markdown
Owner
  • Review chore/bump-py3143 changes;

@qlrd qlrd requested a review from Copilot March 26, 2026 17:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qlrd

qlrd commented Mar 26, 2026

Copy link
Copy Markdown
Owner Author

Review of Copilot comments from selfcustody#230 (bump py3.14.3):

Comment 1any_order=True weakens test:
cACK. Worth checking the test intent, but not blocking.

Comment 2 — Poetry git dep @v0.0.3 in URL, use tag = "v0.0.3":
ACK. Correct Poetry syntax — tag field is the proper way to pin a git dependency version.

Comment 3<=3.14.3 too restrictive, prefer <3.15:
ACK. Valid — current bound rejects future 3.14.x patches.

Comment 4 — Black job across Python matrix is wasteful:
cACK. Nit but reasonable — Black output is Python-version-independent.

@copilot comments 2 and 3 should be addressed. Comment 4 is a valid optimization nit.

Copilot AI commented Mar 26, 2026

Copy link
Copy Markdown

Review of Copilot comments from selfcustody#230 (bump py3.14.3):

Comment 1any_order=True weakens test:...

Addressed in commit e8344af:

  • Comment 2: Fixed Poetry git dependency syntax — changed git = "https://github.com/qlrd/pysudoer.git@v0.0.3" to git = "https://github.com/qlrd/pysudoer.git", tag = "v0.0.3" in pyproject.toml.
  • Comment 3: Changed Python upper bound from <=3.14.3 to <3.15 to allow future 3.14.x patch versions.
  • Comment 4: Removed the matrix from the Black job in tests.yml — it now runs only on Python 3.12, since Black formatting is Python-version-independent.

@qlrd

qlrd commented Mar 26, 2026

Copy link
Copy Markdown
Owner Author

tACK e8344af

Copilot addressed comments 2, 3, and 4. Comment 1 left as cACK (non-blocking).

@copilot all resolved.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml Outdated

[tool.poetry.dependencies]
python = ">3.10,<=3.14.3"
python = ">3.10,<3.15"

Copilot AI Mar 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project Python constraint was broadened to <3.15, but the locked pysudoer dependency is limited to <=3.14.3 (per its package metadata). On Python 3.14.4+ this will likely make poetry install/resolution fail. Either keep the project constraint at <=3.14.3 or bump/update pysudoer (and other deps) to versions that declare support for newer 3.14 patch releases.

Suggested change
python = ">3.10,<3.15"
python = ">3.10,<=3.14.3"

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Valid concern — need to verify pysudoer's declared Python constraint before broadening. If pysudoer caps at 3.14.3, the project bound should match.

Comment thread pyproject.toml Outdated
qrcode = "^8.2"
easy-i18n = "^1.2.0"
pysudoer = { git = "https://github.com/qlrd/pysudoer.git@v0.0.3" }
pysudoer = { git = "https://github.com/qlrd/pysudoer.git", tag = "v0.0.3" }

Copilot AI Mar 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pysudoer was switched to git + tag syntax, but poetry.lock is not updated in this PR. Since CI uses poetry.lock, this can leave installs pinned to whatever is currently locked (often reference = HEAD) and can also trigger Poetry's “pyproject changed significantly” error. Re-run poetry lock (or the repo’s preferred lock update command) and commit the updated lockfile so the tag pin and Python constraint are reflected.

Suggested change
pysudoer = { git = "https://github.com/qlrd/pysudoer.git", tag = "v0.0.3" }
pysudoer = "^0.0.3"

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. poetry.lock must be regenerated after changing dependency syntax. However, suggesting pysudoer = "^0.0.3" (PyPI) is incorrect — pysudoer is not on PyPI, it's a git-only dependency. The lock file just needs a poetry lock run.

@qlrd

qlrd commented Mar 26, 2026

Copy link
Copy Markdown
Owner Author

@copilot please apply the following fix:

  1. Run poetry lock to regenerate the lockfile after the dependency changes;

Note: pysudoer is NOT on PyPI — keep the git + tag syntax, do not change to "^0.0.3".

Agent-Logs-Url:
https://github.com/qlrd/krux-installer/sessions/f349ddb2-7966-4135-a013-4da69407a16e

Signed-of-by: Monsieur Piscinette monsieurpiscinette@selfcustody.org
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@qlrd qlrd force-pushed the chore/bump-py3143-review branch from e8344af to 1c95ef6 Compare March 26, 2026 20:00
@qlrd qlrd merged commit ab03621 into chore/bump-py3143 Mar 26, 2026
1 check passed
@qlrd qlrd deleted the chore/bump-py3143-review branch March 26, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants