review: bump py3.14.3 and pysudoer 0.0.3#25
Conversation
qlrd
commented
Mar 26, 2026
- Review chore/bump-py3143 changes;
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Review of Copilot comments from selfcustody#230 (bump py3.14.3): Comment 1 — Comment 2 — Poetry git dep Comment 3 — Comment 4 — Black job across Python matrix is wasteful: @copilot comments 2 and 3 should be addressed. Comment 4 is a valid optimization nit. |
Addressed in commit
|
|
tACK Copilot addressed comments 2, 3, and 4. Comment 1 left as cACK (non-blocking). @copilot all resolved. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [tool.poetry.dependencies] | ||
| python = ">3.10,<=3.14.3" | ||
| python = ">3.10,<3.15" |
There was a problem hiding this comment.
The project Python constraint was broadened to <3.15, but the locked pysudoer dependency is limited to <=3.14.3 (per its package metadata). On Python 3.14.4+ this will likely make poetry install/resolution fail. Either keep the project constraint at <=3.14.3 or bump/update pysudoer (and other deps) to versions that declare support for newer 3.14 patch releases.
| python = ">3.10,<3.15" | |
| python = ">3.10,<=3.14.3" |
There was a problem hiding this comment.
cACK. Valid concern — need to verify pysudoer's declared Python constraint before broadening. If pysudoer caps at 3.14.3, the project bound should match.
| qrcode = "^8.2" | ||
| easy-i18n = "^1.2.0" | ||
| pysudoer = { git = "https://github.com/qlrd/pysudoer.git@v0.0.3" } | ||
| pysudoer = { git = "https://github.com/qlrd/pysudoer.git", tag = "v0.0.3" } |
There was a problem hiding this comment.
pysudoer was switched to git + tag syntax, but poetry.lock is not updated in this PR. Since CI uses poetry.lock, this can leave installs pinned to whatever is currently locked (often reference = HEAD) and can also trigger Poetry's “pyproject changed significantly” error. Re-run poetry lock (or the repo’s preferred lock update command) and commit the updated lockfile so the tag pin and Python constraint are reflected.
| pysudoer = { git = "https://github.com/qlrd/pysudoer.git", tag = "v0.0.3" } | |
| pysudoer = "^0.0.3" |
There was a problem hiding this comment.
ACK. poetry.lock must be regenerated after changing dependency syntax. However, suggesting pysudoer = "^0.0.3" (PyPI) is incorrect — pysudoer is not on PyPI, it's a git-only dependency. The lock file just needs a poetry lock run.
|
@copilot please apply the following fix:
Note: pysudoer is NOT on PyPI — keep the git + tag syntax, do not change to "^0.0.3". |
Agent-Logs-Url: https://github.com/qlrd/krux-installer/sessions/f349ddb2-7966-4135-a013-4da69407a16e Signed-of-by: Monsieur Piscinette monsieurpiscinette@selfcustody.org Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
e8344af to
1c95ef6
Compare