Add options GEO_CELL_GRID_LEVEL and GEO_CELL_GRID_SCHEME for qlever index - #333
Merged
Conversation
This change passes the new `--geo-cell-grid-level` option of the index builder through from the Qleverfile, so that indices can be built with the geo cell grid for WKT literal IDs (spatial join prefilter).
This change passes the new `--geo-cell-grid-scheme` option of the index builder through from the Qleverfile (values `flat`, `flat-4-shifts`, `hierarchical`, `hierarchical-3-shifts`).
The index tests mock `args`, so the two new options have to be set to `None` explicitly, else they leak into every constructed command line. The expected argument list and the formatting of `qleverfile.py` are adjusted as well.
hannahbast
changed the title
GEO_CELL_GRID_LEVEL and GEO_CELL_GRID_SCHEME for qlever index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds two Qleverfile options in the
[index]section,GEO_CELL_GRID_LEVELandGEO_CELL_GRID_SCHEME, which are passed through to the index builder as--geo-cell-grid-leveland--geo-cell-grid-scheme. With a level > 0, the index builder annotates the IDs of WKT literals with a grid cell, which enables block prefiltering for spatial joins. The scheme option selects the cell assignment (flat,flat-4-shifts,hierarchical,hierarchical-3-shifts).NOTE: At the time of this merge, these options do not yet exist for
qlever-index. The code will be added in a series of PRs derived from ad-freiburg/qlever#3310 over the next weeks.