Adapt qlever monitor-queries to the new resource-usage log and show index rebuilds - #330
Draft
tanmay-9 wants to merge 5 commits into
Draft
Adapt qlever monitor-queries to the new resource-usage log and show index rebuilds#330tanmay-9 wants to merge 5 commits into
qlever monitor-queries to the new resource-usage log and show index rebuilds#330tanmay-9 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ad-freiburg/qlever#3188 and ad-freiburg/qlever#3256, which extend the resource-usage log from four columns to eight:
read_bytes_per_s,write_bytes_per_s,io_stall_percent, andrebuild_id(the id of the index rebuild running at that sample).So far,
monitor-queriesaccepted resource-usage rows of exactly four columns, which breaks against a new resource-usage log with 8 columns. With this change, both formats are now read, so logs from older servers keep rendering exactly as before.The plot also marks index rebuilds: a blue line where a rebuild started and a violet one where it ended, next to the orange and green lines that already mark the server going down and coming back. This works on the Live screen and for any window on the Historic screen.
With four kinds of marker, the legend no longer fits inside the plot and has moved into a heading row above it, which also names the plot (Memory and CPU).
The three remaining new columns (disk read and write rates, and I/O stall) are read but not yet drawn; the plots that use them follow separately.
NOTE: The server rotates the log when its format changes, so after upgrading the server binary the history from before the upgrade sits in a sibling file, which we do not read. The Historic timeline comes from the metrics log, which is not rotated, so a window can reach further back than the resource data goes.