Allow reading query for qlever materialized-view from Qleverfile - #326
Open
ullingerc wants to merge 2 commits into
Open
Allow reading query for qlever materialized-view from Qleverfile#326ullingerc wants to merge 2 commits into
qlever materialized-view from Qleverfile#326ullingerc wants to merge 2 commits into
Conversation
If the user calls `qlever materialized-view NAME QUERY` without a `QUERY`, we now look if a view with name `NAME` is defined in the `Qleverfile` and if yes, use that query. Useful for rewriting a view defined in the `Qleverfile`.
There was a problem hiding this comment.
Pull request overview
Adds a convenience fallback for the qlever materialized-view CLI command: when the query argument is omitted, the command now attempts to read the corresponding query from MATERIALIZED_VIEWS in the Qleverfile (matching the configuration key used by qlever index). This supports iterating on and reloading views defined in the Qleverfile against a running server (per #315).
Changes:
- If
view_queryis omitted, attempt to load it from[index] MATERIALIZED_VIEWSin theQleverfile. - Improve the error message when no query is available from CLI or
Qleverfile.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user calls
qlever materialized-view NAME QUERYwithout aQUERY, we now look if a view with nameNAMEis defined in theQleverfileand if yes, use that query. Useful for rewriting a view defined in theQleverfile. Closes #315