Skip to content

Add support of slurm-26.05 - #199

Merged
ohtanim merged 1 commit into
qiskit-community:mainfrom
ohtanim:fix_bld_err_26_05
Jul 17, 2026
Merged

Add support of slurm-26.05#199
ohtanim merged 1 commit into
qiskit-community:mainfrom
ohtanim:fix_bld_err_26_05

Conversation

@ohtanim

@ohtanim ohtanim commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Description of Change

Added support for Slurm v26.05. The Slurm library(libslurm.so) interface changed as of v26.05, so our spank plugin currently fails to build with the following error. This PR introduces conditional compilation referring to SLURM_VERSION_NUMBER to support both v26.05 and older versions.

/shared/spank-plugins/plugins/spank_qrmi/spank_qrmi.c:560:43: error: incompatible type for argument 2 of ‘slurm_load_job’
  560 |         if (slurm_load_job(&job_info_msg, job_id, SHOW_DETAIL) == SLURM_SUCCESS) {
      |                                           ^~~~~~
      |                                           |
      |                                           uint32_t {aka unsigned int}
In file included from /shared/spank-plugins/plugins/spank_qrmi/spank_qrmi.c:26:
/usr/include/slurm/slurm.h:4256:66: note: expected ‘slurm_step_id_t’ but argument is of type ‘uint32_t’ {aka ‘unsigned int’}
 4256 | extern int slurm_load_job(job_info_msg_t **resp, slurm_step_id_t step_id,
      |                                                  ~~~~~~~~~~~~~~~~^~~~~~~

Checklist ✅

  • Have you included a description of this change?
  • Have you updated the relevant documentation to reflect this change?
  • Have you made sure CI is passing before requesting a review?

Ticket

  • Fixes #
  • Is Part of #

@ohtanim ohtanim self-assigned this Jul 17, 2026
@ohtanim ohtanim added the bug Something isn't working label Jul 17, 2026

@awennersteen awennersteen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Thanks for catching

@ohtanim
ohtanim merged commit 9f527ab into qiskit-community:main Jul 17, 2026
2 checks passed
@ohtanim
ohtanim deleted the fix_bld_err_26_05 branch July 17, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants