Add QRMI_JOB_QPU_<TYPES,RESOURCES> env var backwards compatible - #193
Merged
Conversation
MatthieuMoreau0
approved these changes
Jun 8, 2026
MatthieuMoreau0
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I assume the slurm prefixed env variables are now deprecated. What should be the policy to eventually sunset these?
Maybe a suggestion as well to add a comment in the code to mark them as deprecated
ohtanim
approved these changes
Jun 8, 2026
ohtanim
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Addressing
qiskit-community/qrmi#123
Compared to @ohtanim 's original I favoured keeping
JOBin the env var. Happy to revise that if there are strong opinions. but the reasoning is simply to keep the job resources separately from the defined ones.qiskit-community/qrmi@4007537
I've tested this with Pasqal local and cloud.
From @yoonho's description:
We want QRMI to be resource manager agnostic. This means no mention of specific resource managers in the QRMI code or only when it is absolutely necessary. primitives/service.py looks for SLURM_JOB_QPU_RESOURCES and SLURM_JOB_QPU_TYPES.
So we:
Change SLURM_JOB_QPU_RESOURCES and SLURM_JOB_QPU_TYPES to QRMI_JOB_QPU_RESOURCES and QRMI_JOB_QPU_TYPES
Checklist ✅
Ticket