Skip to content

Add QRMI_JOB_QPU_<TYPES,RESOURCES> env var backwards compatible - #193

Merged
ohtanim merged 1 commit into
mainfrom
aw/resource-manager-agonstic-env-vars
Jun 8, 2026
Merged

Add QRMI_JOB_QPU_<TYPES,RESOURCES> env var backwards compatible#193
ohtanim merged 1 commit into
mainfrom
aw/resource-manager-agonstic-env-vars

Conversation

@awennersteen

Copy link
Copy Markdown
Collaborator

Description of Change

Addressing
qiskit-community/qrmi#123

Compared to @ohtanim 's original I favoured keeping JOB in the env var. Happy to revise that if there are strong opinions. but the reasoning is simply to keep the job resources separately from the defined ones.
qiskit-community/qrmi@4007537

I've tested this with Pasqal local and cloud.

From @yoonho's description:

We want QRMI to be resource manager agnostic. This means no mention of specific resource managers in the QRMI code or only when it is absolutely necessary. primitives/service.py looks for SLURM_JOB_QPU_RESOURCES and SLURM_JOB_QPU_TYPES.

So we:

Change SLURM_JOB_QPU_RESOURCES and SLURM_JOB_QPU_TYPES to QRMI_JOB_QPU_RESOURCES and QRMI_JOB_QPU_TYPES

Checklist ✅

  • [x ] Have you included a description of this change?
  • [ x] Have you updated the relevant documentation to reflect this change?
  • [x ] Have you made sure CI is passing before requesting a review?

Ticket

  • Fixes #
  • Is Part of #

@OkuyanBoga OkuyanBoga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthieuMoreau0 MatthieuMoreau0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I assume the slurm prefixed env variables are now deprecated. What should be the policy to eventually sunset these?

Maybe a suggestion as well to add a comment in the code to mark them as deprecated

@ohtanim ohtanim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@ohtanim
ohtanim merged commit 87500cc into main Jun 8, 2026
2 checks passed
@ohtanim
ohtanim deleted the aw/resource-manager-agonstic-env-vars branch June 8, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants