Skip to content

[FEAT] Option to target specific tag/branch/commit of the QRMI - #186

Merged
ohtanim merged 1 commit into
mainfrom
mm/option-target-qrmi-tag
Apr 20, 2026
Merged

[FEAT] Option to target specific tag/branch/commit of the QRMI#186
ohtanim merged 1 commit into
mainfrom
mm/option-target-qrmi-tag

Conversation

@MatthieuMoreau0

@MatthieuMoreau0 MatthieuMoreau0 commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Description of Change

In this MR I add a new optional flag to target a specific tag/branch/commit of the QRMI when building the spank plugin instead of the main branch (left as default).

cmake -DQRMI_GIT_TAG=v0.3.0 ..
make

Pinning the QRMI version used during the build makes the resulting plugin binary reproducible and prevents unexpected breakage from upstream changes on main.

Checklist ✅

  • Have you included a description of this change?
  • Have you updated the relevant documentation to reflect this change?
  • Have you made sure CI is passing before requesting a review?

Ticket

  • Fixes #
  • Is Part of #

@awennersteen awennersteen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ohtanim ohtanim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MatthieuMoreau0
MatthieuMoreau0 force-pushed the mm/option-target-qrmi-tag branch from 38a3093 to 8865cc3 Compare April 20, 2026 09:34
@ohtanim ohtanim added the enhancement New feature or request label Apr 20, 2026
@ohtanim
ohtanim merged commit 4d23a6d into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants