Skip to content

Aqpu active reset test for hardware - #958

Draft
jordivallsq wants to merge 35 commits into
mainfrom
AQPU-active-reset
Draft

Aqpu active reset test for hardware#958
jordivallsq wants to merge 35 commits into
mainfrom
AQPU-active-reset

Conversation

@jordivallsq

Copy link
Copy Markdown
Contributor

No description provided.

jordivallsq and others added 30 commits June 11, 2025 14:41
This reverts commit 3f2a5c0.
This reverts commit b218aeb.
This reverts commit dec2e88.
@pullpo-for-slack

pullpo-for-slack Bot commented Jul 21, 2025

Copy link
Copy Markdown

AI Analysis

of the newly committed changes

Purpose of the changes:

The changes primarily focus on enhancing the Qblox module's test coverage and functionality, particularly around the handling of scope-related parameters and their interactions within the QbloxQRM class.

Improvements and suggestions

(dropdown):
  • In file src/qililab/instruments/qblox/qblox_qrm.py / _obtain_scope_sequencer

Issue:
The logic for setting and resetting the scoping sequencer can lead to confusion; the raise statement for ValueError is placed incorrectly, which could cause issues in managing sequencer states.

Suggested solution:
Refactor the method to clearly separate the logic for setting the scoping sequencer and handling errors, ensuring that errors are raised only when appropriate.

Detailed file changes

(dropdown):
  • In file tests/instruments/qblox/test_qblox_qrm.py:

    • Added a new test case for setting the SCOPE_STORE_ENABLED parameter to ensure it behaves correctly across different scenarios.
    • Updated existing tests to include additional assertions for new functionality and error handling.
    • Refactored tests to improve readability and maintainability.
  • In file src/qililab/instruments/qblox/qblox_qrm.py:

    • Improved the logic in _obtain_scope_sequencer to handle the assignment of the scoping sequencer more clearly.
    • Added additional calls to set acquisition mode and hardware averaging when enabling scope storage, enhancing functionality.
    • Refactored error handling to manage the state of the scoping sequencer more effectively.
  • In file docs/releases/changelog-dev.md:

    • Updated the changelog to reflect recent improvements and bug fixes related to the Qblox module and its handling of parameters.
    • Added detailed descriptions of changes made to the VNA Driver and Qblox Draw functionalities.

@pullpo-for-slack

pullpo-for-slack Bot commented Jul 21, 2025

Copy link
Copy Markdown

AI Analysis

of the newly committed changes

Purpose of the changes:

This commit enhances the test fixtures for the SGS100A class by refining the operational parameters and introducing new test cases to validate the operation modes.

Detailed file changes

(dropdown):
  • In file tests/instruments/rohde_schwarz/test_rohde_schwarz_sgs100a.py:

    • Updated multiple test fixtures to reflect the correct alias for SGS100A instead of QDAC-II.
    • Introduced new fixtures for bypass and incorrect operation modes to expand testing coverage.
    • Added assertions in existing tests to validate the operation mode parameter during setup.
  • In file src/qililab/instruments/rohde_schwarz/sgs100a.py:

    • Added operation_mode property to the SGS100ASettings class to manage the operation mode of the device.
    • Enhanced the set_parameter method to handle operation mode changes and added validation for allowed values.
    • Implemented logic in initial_setup to write the correct operation mode to the device and handle warnings for invalid modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant