Qcnn devel - #221
Conversation
shangtai
left a comment
shangtai
left a comment
There was a problem hiding this comment.
Reminder to include pytests and update the documentations as well.
| self.nlayers = nlayers | ||
|
|
||
|
|
||
| twoqubitansatz = None |
There was a problem hiding this comment.
twoqubitansatz is an input to the init in line 70 right? If we set it to None here, it would defeat the purpose of taking in the input right?
|
|
||
| Args: | ||
| bits: the two qubits to apply the unitaries to | ||
| symbols: length 15 array containing the parameters |
There was a problem hiding this comment.
bits is assumed to be of length 15, would be good to use assertion to catch if a user input bits of different lengths.
|
|
||
| Args: | ||
| bit: the qubit to apply the one-qubit unitaries to | ||
| symbols: length 3 array containing the parameters |
There was a problem hiding this comment.
use assertion to validate that symbols have length 3.
There was a problem hiding this comment.
Assertions not done yet, is this by choice?
|
@shangtai could you please have a look at these changes. @renatomello @MatteoRobbiati could you please check if this implementation looks consistent with QiboML? |
shangtai
left a comment
shangtai
left a comment
There was a problem hiding this comment.
Are we including any pytest for Qcnn?
|
|
||
| Args: | ||
| bit: the qubit to apply the one-qubit unitaries to | ||
| symbols: length 3 array containing the parameters |
There was a problem hiding this comment.
Assertions not done yet, is this by choice?
|
|
||
| Args: | ||
| bits: the two qubits to apply the unitaries to | ||
| symbols: length 15 array containing the parameters |
3 participants
qcnn.py was copied from qibo/models but it should be put under qiboml/models. Now it supports 3 variants of QCNN, i.e., QCNNCOMPLEX, QCNNREAL, QCNNRY.