Replace qq auto with qq run - #993
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 97.33% 97.32% -0.01%
==========================================
Files 120 120
Lines 9747 9756 +9
==========================================
+ Hits 9487 9495 +8
- Misses 260 261 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@scarrazza do you think we can go on with this PR and update the Qibocal-paper before the submission? |
|
Yes, I agree. |
andrea-pasquale
left a comment
There was a problem hiding this comment.
Thanks @Edoardo-Pedicillo.
In theory we need to update the diagram that we have in the qibocal paper also here in the documenation, correct? Maybe it is worth waiting until the diagram is ready to merge the PR.
Also, perhaps we could add a log message when importing the library saying that qq auto has been renamed qq run? It could also makes sense to do it once we have a release I guess. I'm suggesting this to lower the confusion among users :)
I would exclude doing that at import time (it would appear also in any script not using the CLI), and I'm generally against warnings. What I may support is to keep the |
This could work. |
This choice comes from some internal discussions, the most recent one is qiboteam/xmind-diagrams#31 (comment)
Checklist:
master0.1main