Skip to content

review and improvement of readout optimization protocols - #1688

Draft
lballerio wants to merge 4 commits into
mainfrom
readout_optimization_review
Draft

review and improvement of readout optimization protocols#1688
lballerio wants to merge 4 commits into
mainfrom
readout_optimization_review

Conversation

@lballerio

@lballerio lballerio commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

As per statement.

  1. filenames and protocols names were changed
  2. In ro_amplitude protocol, I added the Sweeper syntax for performance improvement.
  3. Now IQ measurements are saved during acquisition, while the classification is being moved during fitting.

@alecandido

Copy link
Copy Markdown
Member

Quick comment: also the resonator_optimization can be renamed to readout_optimization, and, for the files

  • either you drop the _optimization suffix, since they are in the readout_optimization/ folder
  • or, even better, just keep the current names, and move the files into the readout/ folder, we do not really need infinite many folders

Target a specific issue. If you are addressing multiple ones, let's discuss (even briefly).

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.08284% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.34%. Comparing base (d99e818) to head (5705297).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
...rc/qibocal/protocols/readout_optimization/utils.py 89.89% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   90.47%   90.34%   -0.13%     
==========================================
  Files         151      152       +1     
  Lines       12225    12195      -30     
==========================================
- Hits        11060    11018      -42     
- Misses       1165     1177      +12     
Flag Coverage Δ
unittests 90.34% <94.08%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...qibocal/protocols/readout_optimization/__init__.py 100.00% <100.00%> (ø)
...t_optimization/amplitude_frequency_optimization.py 98.83% <ø> (ø)
...ols/readout_optimization/amplitude_optimization.py 100.00% <100.00%> (ø)
...ols/readout_optimization/frequency_optimization.py 100.00% <100.00%> (ø)
...rc/qibocal/protocols/readout_optimization/utils.py 89.89% <89.89%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants