Improve conditional oscillations - #1564
Draft
alecandido wants to merge 9 commits into
Draft
Conversation
alecandido
force-pushed
the
conditional-oscillations
branch
2 times, most recently
from
June 25, 2026 16:55
0d31ca6 to
6289658
Compare
Remove gate repetitions. Assuming they were a leftover, initially used for debugging the repeated application, when discovering the charge accumulation
alecandido
force-pushed
the
conditional-oscillations
branch
from
August 18, 2026 14:01
d3295d5 to
88640ec
Compare
alecandido
commented
Aug 18, 2026
Comment on lines
+61
to
+77
| sweep: bool = True | ||
| """Toggle sweeping vs unrolling. | ||
|
|
||
|
|
||
| .. tip:: | ||
|
|
||
| Sweeping phases has been proven fragile in certain platforms. For this reason, we | ||
| are now providing the double implementation. | ||
| The difference it is just an internal detail, and ideally the result is supposed | ||
| to be the exact same when sweeping phases is properly supported. Sweeping is | ||
| often a bit faster. | ||
|
|
||
| The recommended usage is just to toggle this to ``False`` when the user is | ||
| confident the sweeping is not working properly. Or just to check whether that is | ||
| actually the problem or not. | ||
|
|
||
| """ |
Member
Author
There was a problem hiding this comment.
I wonder whether I should now remove this. It was introduced mostly for Qblox.
And a bit faster is of course an euphemism. Especially, taking into account the per-job overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.