Skip to content

reuse same rectangular pulse (unique UUID) - #1542

Draft
jevillegasd wants to merge 4 commits into
spin_lock_spectroscopyfrom
sls_unique_pulse_reference
Draft

reuse same rectangular pulse (unique UUID)#1542
jevillegasd wants to merge 4 commits into
spin_lock_spectroscopyfrom
sls_unique_pulse_reference

Conversation

@jevillegasd

Copy link
Copy Markdown
Contributor

Here I am testing defining just one pulse that is repeated many times (shared UUID?) so that when I run the sweep, I iterate for a shorter range (duration/n, where n is the number of times we repeat the pulse) and hope that this way all the repeated pulses in the sequence are swept, effectively getting a longer range.

This only works for back to back rectangular pulses, but could be extended for pulses with a transition.

In practice this is actually not working and I halt at the same

assert sum(len(w.data) for w in waveforms) <= WAVEFORM_MEMORY

My only guess being that there is no de-duplication based on UUID. The sequence is indeed re-using the UUID, like in

[
    (
        '0/drive',
        Pulse(
            id_=UUID('ceaf44d6-45f8-4090-a1d5-0849410e1b15'),
            kind='pulse',
            duration=40.0,
            amplitude=0.17976076552362769,
            envelope=Drag(
                kind='drag',
                rel_sigma=0.25,
                beta=-0.8877200835178028
            ),
            relative_phase=1.5707963267948966,
            chirp=None
        )
    ),
    (
        '0/drive',
        Pulse(
            id_=UUID('6136982d-43cf-4968-95a4-e9c94e88e7c4'),
            kind='pulse',
            duration=26.0,
            amplitude=0.001,
            envelope=Rectangular(kind='rectangular'),
            relative_phase=0.0,
            chirp=None
        )
    ),
    (
        '0/drive',
        Pulse(
            id_=UUID('6136982d-43cf-4968-95a4-e9c94e88e7c4'),
            kind='pulse',
            duration=26.0,
            amplitude=0.001,
            envelope=Rectangular(kind='rectangular'),
            relative_phase=0.0,
            chirp=None
        )
    ),
    ...

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.27%. Comparing base (b00f190) to head (b13a786).

Files with missing lines Patch % Lines
src/qibocal/protocols/coherence/spin_lock.py 28.00% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           spin_lock_spectroscopy    #1542      +/-   ##
==========================================================
- Coverage                   93.40%   93.27%   -0.13%     
==========================================================
  Files                         137      137              
  Lines                       10809    10830      +21     
==========================================================
+ Hits                        10096    10102       +6     
- Misses                        713      728      +15     
Flag Coverage Δ
unittests 93.27% <28.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/coherence/spin_lock.py 35.89% <28.00%> (-0.31%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant