improve intial parameters guess Lorentzian fit - #1492
Merged
Conversation
alecandido
reviewed
May 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
- Coverage 94.43% 94.38% -0.06%
==========================================
Files 136 136
Lines 10662 10669 +7
==========================================
+ Hits 10069 10070 +1
- Misses 593 599 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
RoyStegeman
marked this pull request as ready for review
May 12, 2026 14:30
alecandido
approved these changes
May 14, 2026
alecandido
left a comment
Member
There was a problem hiding this comment.
The first two comments are stylistic.
The other two need to be addressed in a separate PR. But, if you agree with them, better to write them down in suitable issues immediately
alecandido
approved these changes
May 15, 2026
alecandido
reviewed
May 15, 2026
scarrazza
approved these changes
May 15, 2026
RoyStegeman
force-pushed
the
review_resonator
branch
from
May 15, 2026 10:16
5c7cf59 to
a5656ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1408
The fits in #1408 that before failed now pass.
The background was made linear in an earlier PR. In this PR we heavily rely on the assumption of a linear background to make the guesses for the initial parameters so it is stable only up to a point where the background is linear enough.
Specifically what changed are the following things: