Skip to content
Open

Long t1 #1366

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/qibocal/protocols/coherence/t1.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ def _acquisition(
params: T1Parameters, platform: CalibrationPlatform, targets: list[QubitId]
) -> T1Data:
"""Data acquisition for T1 experiment."""

num_delays = int(params.delay_before_readout_end // 65004) + 1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the maximum size stored somewhere in the driver object, maybe we can read from there instead of hard coding it here.

sequence, ro_pulses, pulses = t1_sequence(
platform=platform,
targets=targets,
num_delays=num_delays,
)

ro_wait_range = np.arange(
Expand All @@ -62,7 +63,7 @@ def _acquisition(

sweeper = Sweeper(
parameter=Parameter.duration,
values=ro_wait_range,
values=ro_wait_range // num_delays,
pulses=pulses,
)

Expand Down
13 changes: 8 additions & 5 deletions src/qibocal/protocols/coherence/t1_signal.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,13 @@ def t1_sequence(
platform: CalibrationPlatform,
targets: list[QubitId],
flux_pulse_amplitude: Optional[float] = None,
num_delays: int = 1,
):
"""Create sequence for T1 experiment with a given optional delay."""
sequence = PulseSequence()
ro_pulses = {}
delays = len(targets) * [Delay(duration=0)]

delays = num_delays * len(targets) * [Delay(duration=0)]
for i, q in enumerate(targets):
natives = platform.natives.single_qubit[q]
qd_channel, qd_pulse = natives.RX()[0]
Expand All @@ -101,7 +103,8 @@ def t1_sequence(
sequence.append((flux_channel, flux_pulses[i]))
else:
flux_pulses = []
sequence.append((ro_channel, delays[i]))
for j in range(num_delays):
sequence.append((ro_channel, delays[i * num_delays + j]))
sequence.append((ro_channel, ro_pulse))

return sequence, ro_pulses, delays + flux_pulses
Expand All @@ -113,8 +116,8 @@ def _acquisition(
"""Data acquisition for T1 experiment.

In this protocol the y axis is the magnitude of signal in the IQ plane."""

sequence, ro_pulses, pulses = t1_sequence(platform, targets)
num_delays = int(params.delay_before_readout_end // 65004) + 1
sequence, ro_pulses, pulses = t1_sequence(platform, targets, num_delays=num_delays)

ro_wait_range = np.arange(
params.delay_before_readout_start,
Expand All @@ -124,7 +127,7 @@ def _acquisition(

sweeper = Sweeper(
parameter=Parameter.duration,
values=ro_wait_range,
values=ro_wait_range // num_delays,
pulses=pulses,
)

Expand Down