Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated lockfile appears to make the qulacs extra install by default (and the lock was generated with a different Poetry version), which can unexpectedly change default dependencies and harm reproducibility.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates Qibo’s declared and tested Python support baseline by removing Python 3.10, aligning packaging metadata, lint configuration, CI matrices, and installation docs around Python ≥3.11.
Changes:
- Bump project Python requirement from
>=3.10to>=3.11and update Rufftarget-versiontopy311. - Refresh
poetry.lockto reflect the new Python constraint and dependency markers. - Remove Python 3.10 from GitHub Actions test/deploy matrices and update installation documentation accordingly.
File summaries
| File | Description |
|---|---|
| pyproject.toml | Raises minimum supported Python to 3.11 and updates Ruff target version. |
| poetry.lock | Re-locks dependencies under the new Python constraint and adjusts markers/versions. |
| doc/source/getting-started/installation.rst | Updates installation docs to state Python 3.11+ requirement. |
| .github/workflows/rules.yml | Drops Python 3.10 from the CI test matrix. |
| .github/workflows/deploy.yml | Drops Python 3.10 from the deploy/build matrix. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 78 78
Lines 14095 14095
=======================================
Hits 14032 14032
Misses 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RoyStegeman
left a comment
There was a problem hiding this comment.
This one you may want to update as well (or remove the explicit version number and assume a user can figure that out)
qibo/doc/source/getting-started/quickstart.rst
Lines 4 to 5 in b727a65
|
Thanks @RoyStegeman and @alecandido. |
No description provided.