Repository navigation
feat(input): add pointer-focus delay configuration - #130
Merged
Merged
Conversation
- New config option focus_follows_mouse_delay_ms (0–1000 ms, default 50) - Pointer must rest for configured delay before focus follows - Applies only when focus_follows_mouse is enabled - Add UI slider control and search target in settings - Add validation and decoding tests
|
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a user-facing pointer-focus delay and changes the existing focus-following path to wait 50 ms by default, with configuration persistence and settings UI spanning multiple runtime layers. Existing users who enabled pointer focus do not retain the previous immediate behavior automatically, so the change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
Extract the pointer-focus rest delay into a testable helper and cover zero delay, elapsed delay, and cancellation by newer motion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
focus_follows_mouse_delay_msconfiguration option (0–1000ms, default 50ms)focus_follows_mouseis enabled; 0ms focuses immediatelyTesting
focus_follows_mousetoggleNote
Add configurable pointer-focus delay (
input.focus_follows_mouse_delay_ms)InputConfigand validated inConfig.validatein Config.swiftDaemon.handlePointerMotionnow awaits the newpointerFocusRestDelayElapsedhelper before hit testing. Each new motion cancels the prior pending wait; a zero delay skips waiting entirely. See DaemonFocus.swiftMacroscope summarized 314c5cf.