Repository navigation
perf: improve responsiveness for 120 Hz displays - #123
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 49 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a large production-path redesign affecting accessibility reads and writes, window discovery scheduling, focus handling, border rendering, and frame verification rather than a narrowly scoped responsiveness tweak. The unresolved review comments also identify retry-timing, host-dependent test, and extra-mutation risks that require human assessment. Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
Summary
Testing
python3 script/verify.py local— not run in this content-generation task.Note
Improve display responsiveness: async border-geometry reads, incremental discovery, and retry scheduling
AXFrameCoordinator, so repeated requests for the same window collapse into one read and observations are delivered as a batch on the main actorSnapshotEngine.prepareIncrementalDiscoveryReadsreuses cached element bindings and window attributes, defers processes that need no read, and schedules per-process unmatched-window retries with deadlinesSnapshotEngine, with commit IDs, scheduled/requested/watchdog states, and due-verification checks wired into the daemon refresh and desktop-sync decisionsDelayedObservationCampaigns, so stale deliveries are discardedscript/performance_experiments.pyAXFrameWriterskips Accessibility mutations when the focus request is no longer current.MacOSPlatform.refreshWindowBorderGeometry(for:)was removed in favor of the queued multi-window path.Macroscope summarized 6bb25c2.