Repository navigation
chore: prepare Defi 0.4.0 release - #122
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
PASS+NOTES. Independent review found no actionable defect in the base-to-head diff.
Independently ran the four focused native tests via Compared the parent target-selection code with the recorded failure logs. Those tests selected arbitrary user windows. The replacement fixtures are separate regular native applications with distinct bundle IDs and PIDs, normal-level windows, and bounded teardown. No production focus source changed. The documented explicit public AXRaise implementation proves Defi's raise-request integration. Third-party and default AppKit inactive ordering remain outside this evidence. The current source-content digest matches the recorded local staging and full desktop runs. The full desktop record has 45 passes, zero failures, and five multi-monitor skips, with Accessibility available and session restoration passed. Multi-monitor qualification remains incomplete. After my focused run, exactly one installed defi-daemon remained and no fixture children remained. Both commands exited successfully. Logs are Independent review agent; same model family under the personal profile. CI watching and landing remain with the root agent. |
|
| XCTAssertTrue(focusedWindow.map { CFEqual($0, tiledElement) } == true) | ||
| XCTAssertEqual(NSWorkspace.shared.frontmostApplication?.processIdentifier, processID, | ||
| "The tiled fixture must retain real keyboard focus") |
There was a problem hiding this comment.
In testTiledFocusKeepsFloatingWindowAboveIt, the final focus assertions record failures but do not stop the test. If the user switches applications after the earlier guarded check, the test still posts a global a key into their application. Make these final checks throw or return before posting the key.
Summary
Prepare Defi 0.4.0 (build 8) and make four native focus tests independent of whichever user applications happen to be open.
Compile the fixture before reserving the desktop. Keep bounded cleanup and native focus, suppression, event, stacking, and keyboard assertions. Production focus code is unchanged.
Evidence
Executed 50 tests, with 5 tests skipped and 0 failures. Accessibility available; session restoration passed; one daemon remained and no fixture children survived.Merge Danger
Door: Two-way for test infrastructure and version metadata; publication is a separate action.
Blast Radius: Verification. Desktop fixture build and lifecycle affect native test execution; production focus behavior is unchanged.
Note
Prepare Defi 0.4.0 release with deterministic desktop focus test fixtures
ExplicitAXRaiseWindow.accessibilityPerformRaiseoverrideverify.pynow goes throughscript/test_desktop.sh, andrun-built-testsfails if the fixture binary is missing; see test_workflow.py for the updated expectationsMacroscope summarized 90d09d3.