Skip to content

feat(settings): add searchable settings sidebar - #121

Merged
qeude merged 2 commits into
mainfrom
t3/search-settings-sidebar
Oct 7, 2026
Merged

qeude merged 2 commits into
mainfrom
t3/search-settings-sidebar

Conversation

@qeude

@qeude qeude commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add searchable settings results that link directly to settings and shortcut actions.
  • Reveal matching controls, including advanced options, named workspace fields, and filtered shortcuts.
  • Add unit and desktop UI coverage for settings search.

Testing

  • Not run

View guided diff Turn on auto-fix

Note

Add searchable settings sidebar with page, option, shortcut, and workspace results

  • Adds a settings search catalog in SettingsSearch.swift with case-insensitive, all-token matching across labels, config keys, shortcut names, key aliases, and workspace fields. Selecting a result navigates to its page and reveals the matching control.
  • Splits the settings sidebar between page navigation and search results, backed by a native NSSearchField in SettingsSearchField.swift that updates the query while typing and transfers Down-arrow to the first result.
  • Adds SettingsRevealModifier, which expands Advanced sections, prepares content, and scrolls to the target anchor after the view renders. Re-selecting the same destination creates a new reveal request.
  • Selecting a shortcut result sets an exact command filter in input settings; selecting a removed workspace or shortcut destination falls back to its owning page.
  • Covered by new unit tests in SettingsSearchTests.swift and AppKit-driven end-to-end tests in DesktopE2ETests.swift.

Macroscope summarized 5570be9.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread Sources/DefiMacOS/SettingsSearch.swift
Comment thread Sources/DefiMacOS/SettingsSearch.swift
@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Adds searchable settings sidebar with new UI components.

The changes appear safe to merge, with no outstanding findings.

What we checked:

  • Blank searches keep shortcuts visible: The first guard returns true for blank input, so the shortcut list keeps every command. The second guard only rejects nonblank input that becomes empty after separators are removed.
Summary

Adds a searchable settings sidebar that opens matching controls, expands advanced options, and filters shortcut actions.

  • The latest changes reject separator-only searches while keeping blank shortcut searches unchanged.
  • Desktop coverage now checks shortcut visibility and repeated selection of an advanced option.
  • The previous coverage finding is addressed. No new actionable issues were found.
  • Tests and native UI capture were not run; this environment is Linux, while the changed UI requires macOS.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Search[Search settings] --> Catalog[Find matching results]
  Catalog --> Select[Select a result]
  Select --> Page[Open its settings page]
  Page --> Prepare[Expand advanced options or filter shortcuts]
  Prepare --> Reveal[Scroll to the matching control]
Loading

Reviews (2) · Last reviewed commit: "fix: address PR review feedback (#121)" · Reviewed by Greptile

Comment thread Tests/DefiMacOSTests/DesktopE2ETests.swift
@macroscopeapp

macroscopeapp Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a substantial searchable-settings workflow with new production components, dynamic result generation, native input handling, and cross-page reveal behavior. Its scope and state/navigation complexity exceed a small additive UI change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

@qeude
qeude merged commit 74adc43 into main Oct 7, 2026
5 checks passed
@qeude
qeude deleted the t3/search-settings-sidebar branch October 7, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant