Repository navigation
feat(overview): add experimental ribbon window animations - #120
Conversation
|
There was a problem hiding this comment.
All reported issues were addressed across 55 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces substantial new ScreenCaptureKit/AVFoundation rendering and native window-animation behavior across Overview, layout commands, and Accessibility coordination. Despite opt-in defaults and fallbacks, its sensitive screen-content handling, resource implications, and broad runtime changes warrant human review. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 28 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 28 files (changes from recent commits).
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
2 issues found across 9 files (changes from recent commits).
Confidence score: 3/5
OverviewController.swift: Enabling ribbon representations while Overview is already open leaves ribbon animations unavailable until Overview is reopened. Prepare the renderer and capture contexts when the setting changes.OverviewSurfaceCapture.swift: A surface can remain warming without a retry if the desired list changes away from and back to it while capture is in flight. Ensure completion schedules another capture when the request is still desired.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Sources/DefiMacOS/OverviewController.swift">
<violation number="1" location="Sources/DefiMacOS/OverviewController.swift:581">
P2: Enabling ribbon representations while Overview is already open only changes this flag; the renderer and capture contexts are prepared only by `prepare()`, so ribbon animations remain unavailable until Overview is reopened. Refresh the renderer preparation when this setting changes.</violation>
</file>
<file name="Sources/DefiMacOS/OverviewSurfaceCapture.swift">
<violation number="1" location="Sources/DefiMacOS/OverviewSurfaceCapture.swift:182">
P2: A request skipped here can remain uncaptured if the desired list changes away and returns to `requested` before this task finishes: `prepare` then cancels the queued retry, and completion leaves the set warming without another attempt. Re-queue skipped work when its request becomes desired again.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Summary
Testing
Note
Add experimental ribbon window animations and opt-in surface transitions to Overview
shouldDeferAnimatedSizeUntilMovementCompletesin FrameCommit.swift andConfig.validationin Config.swift.Macroscope summarized acdb42f.