Skip to content

Enable faulthandler and force OFF_SCREEN by default - #294

Open
banesullivan wants to merge 2 commits into
mainfrom
faulthandler-offscreen-defaults
Open

Enable faulthandler and force OFF_SCREEN by default#294
banesullivan wants to merge 2 commits into
mainfrom
faulthandler-offscreen-defaults

Conversation

@banesullivan

Copy link
Copy Markdown
Member

Every downstream PyVista project sets faulthandler.enable() and pyvista.OFF_SCREEN = True on its own, and the ones that forget get opaque segfaults or hanging headless CI. The plugin now does both: faulthandler is enabled when the plugin is imported, and OFF_SCREEN is forced during configuration.

Behavior change: a project that intentionally runs on-screen under pytest must set pyvista_off_screen = false. faulthandler is enabled unconditionally at import with no opt-out.

resolves #276

@codecov-commenter

codecov-commenter commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (4129aa4) to head (af4a4ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   95.79%   95.81%   +0.02%     
==========================================
  Files           4        4              
  Lines         998     1003       +5     
  Branches      131      132       +1     
==========================================
+ Hits          956      961       +5     
  Misses         30       30              
  Partials       12       12              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

faulthandler and pv.OFF_SCREEN as Defaults

3 participants