Skip to content

fix: gracefully handle invalid specifiers in vulnerability DB (#873) #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raywcm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gracefully handle invalid specifiers in vulnerability DB (#873) #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions safety/scan/ecosystems/python/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

from packaging.version import parse as parse_version
from packaging.utils import canonicalize_name
from packaging.specifiers import SpecifierSet
from packaging.specifiers import InvalidSpecifier, SpecifierSet


LOG = logging.getLogger(__name__)
Expand Down Expand Up @@ -338,7 +338,14 @@ def __find_dependency_vulnerabilities__(
if name in vulnerable_packages:
# we have a candidate here, build the spec set
for specifier in db["vulnerable_packages"][name]:
spec_set = SpecifierSet(specifiers=specifier)
try:
spec_set = SpecifierSet(specifiers=specifier)
except InvalidSpecifier:
LOG.warning(
"Skipping invalid specifier '%s' for package '%s'",
specifier, name
)
continue

if spec.is_vulnerable(spec_set, dependency.insecure_versions):
if not db_full:
Expand Down