fix(events): support httpx without NetworkError#861
Draft
Mirochill wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the import-time failure when Safety is used with httpx versions that no longer expose
httpx.NetworkError.The retry exception tuple now comes from a small compatibility helper that prefers
NetworkErrorwhen available, then falls back to concrete network error classes (ConnectError,ReadError,WriteError,CloseError) before broader httpx bases. The enrollment transient-error wrapper uses the same helper so exception handling does not reintroduce the same missing-attribute failure.Type of Change
Related Issues
Fixes #860
Testing
Not run locally.
Checklist
Additional Notes
Opened as draft so maintainers can decide whether this is the preferred compatibility boundary for httpx 1.0 pre-releases.