Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

[aarch64] patch mkldnn acl inner product to accelerate torch.compile() for bert#1631

Open
snadampal wants to merge 1 commit into
pytorch:mainfrom
snadampal:aarch64_acl_ip
Open

[aarch64] patch mkldnn acl inner product to accelerate torch.compile() for bert#1631
snadampal wants to merge 1 commit into
pytorch:mainfrom
snadampal:aarch64_acl_ip

Conversation

@snadampal

Copy link
Copy Markdown
Contributor

No description provided.

@malfet malfet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, patch mkldnn to fix build errors is probably appropriate, but feature work should be done on the appropriate repository.

So lets work with onednn to get this fix landed into their default branch and then probably update a release branch

Also, can you please clarify, if this is a regression from previos release or just a new feature?

@snadampal

snadampal commented Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Hi @malfet , this is the PR for oneDNN repo which will be merged for oneDNN 3.4. But the oneDNN3.4 may not be available for PyTorch 2.2 timeline. and this change is mandatory to get torch.compile() performance improvements on aarch64.

@malfet

malfet commented Dec 9, 2023

Copy link
Copy Markdown
Contributor

@snadampal I understand the sentiment, but:

  • oneDNN PR is not merged yet
  • It's already past the deadline for 2.2 branch cut (and this is a feature work isn't it?)
  • There are no test plan (and CI does not test it at all)
  • Builder is not the right place to apply patches, as it prevents users, who will checkout 2.2 release branch from build package identical to the one being published (all previous patches were to unblock the builds/fix fundamental regressions)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants