Skip to content

Fix #2867 #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Whning0513 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #2867 #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions soundfile_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
"""
with soundfile.SoundFile(filepath, "r") as file_:
if file_.format != "WAV" or normalize:
# When reading non-WAV formats (e.g. MP3) with normalize=True,
# use the native floating-point dtype for the subtype if available,
# falling back to float32. This ensures correct reading of files
# that require float64 precision (e.g. certain MP3 files with
# DOUBLE subtype). For integer subtypes, float32 is used for
# normalization.
subtype_dtype = _SUBTYPE2DTYPE.get(file_.subtype)
if subtype_dtype in ("float64",):
dtype = "float64"
else:
dtype = "float32"
elif file_.subtype not in _SUBTYPE2DTYPE:
raise ValueError(f"Unsupported subtype: {file_.subtype}")
else:
17 changes: 17 additions & 0 deletions soundfile_backend_original.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
"""
with soundfile.SoundFile(filepath, "r") as file_:
if file_.format != "WAV" or normalize:
# When reading non-WAV formats (e.g. MP3) with normalize=True,
# use the native floating-point dtype for the subtype if available,
# falling back to float32. This ensures correct reading of files
# that require float64 precision (e.g. certain MP3 files with
# DOUBLE subtype). For integer subtypes, float32 is used for
# normalization.
subtype_dtype = _SUBTYPE2DTYPE.get(file_.subtype)
if subtype_dtype in ("float64",):
dtype = "float64"
else:
dtype = "float32"
elif file_.subtype not in _SUBTYPE2DTYPE:
raise ValueError(f"Unsupported subtype: {file_.subtype}")
else: