GH-150516: Reduce the work done to spill and reload the stack around calls#151587
Open
markshannon wants to merge 2 commits into
Open
GH-150516: Reduce the work done to spill and reload the stack around calls#151587markshannon wants to merge 2 commits into
markshannon wants to merge 2 commits into
Conversation
Member
Author
|
Skipping news as this has no impact on any users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids needless spilling of the stack around calls, as described in the issue.
Also adds the
stackpointer_validto frames in the debug build to verify that the frame's stack pointer is not used when it shouldn't be.frame->stackpointer_validis equivalent to the oldframe->stackpointer != NULLcheck.The new scheme is more precise, so I needed to change a few stack saving/syncing/reloading operations to better reflect the true semantics.