gh-151575: Emit DeprecationWarning in mimetypes.guess_type() for file…#151576
Open
NaveenKumarG-dev wants to merge 2 commits into
Open
gh-151575: Emit DeprecationWarning in mimetypes.guess_type() for file…#151576NaveenKumarG-dev wants to merge 2 commits into
NaveenKumarG-dev wants to merge 2 commits into
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR completes the formal deprecation cycle for passing file paths into
mimetypes.guess_type().As noted by the long-standing
# TODOinLib/mimetypes.py,guess_type()is intended strictly for URLs. The functionguess_file_type()was added in Python 3.13 as the preferred alternative, and the documentation was updated with a.. soft-deprecated:: 3.13directive at that time. However, the runtime warning was never implemented.Changes Made
mimetypes.MimeTypes.guess_type()to emit aDeprecationWarning(withstacklevel=2) when it detects a file path instead of a valid URL.bytesobjects, andos.PathLikeobjects. Valid URLs (likehttp://,ftp://, ordata:) bypass the warning.GuessTypeDeprecationTestCasetoLib/test/test_mimetypes.pycovering all the path and URL permutations to ensure correct behavior and avoid regressions... soft-deprecated:: 3.13directive to.. deprecated:: 3.16inDoc/library/mimetypes.rst.Doc/whatsnew/3.16.rstandDoc/deprecations/pending-removal-in-future.rst.blurb.Linked Issue
Fixes #151575
Code of Conduct and CLA
mimetypes.guess_type()#151575