[wip] PyREPL: Add ctrl+up/down for multiline history#151569
Draft
edvilme wants to merge 3 commits into
Draft
Conversation
Currently, the up/down keys move the cursor in that direction inside the current code block until it reaches the beginning/end, then it goes to the previous/next. However, when traversing history with lots of multiline blocks, this can be a cumbersome process. This PR introduces the ability to traverse history one block at a time using the CTRL+Up or CTRL+Down keys. Originated from https://discuss.python.org/t/pyrepl-add-ctrl-up-down-for-multiline-history-retrieving/107779
Member
|
Good news, this is already implemented as Ctrl+P and Ctrl+N! cpython/Lib/_pyrepl/historical_reader.py Lines 56 to 71 in a064b32 cpython/Lib/_pyrepl/historical_reader.py Lines 261 to 262 in a064b32 See https://discuss.python.org/t/pyrepl-add-ctrl-up-down-for-multiline-history-retrieving/107779/4 for more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the up/down keys move the cursor in that direction inside the current code block until it reaches the beginning/end, then it goes to the previous/next. However, when traversing history with lots of multiline blocks, this can be a cumbersome process.
This PR introduces the ability to traverse history one block at a time using the CTRL+Up or CTRL+Down keys.
Originated from https://discuss.python.org/t/pyrepl-add-ctrl-up-down-for-multiline-history-retrieving/107779