Skip to content

gh-150966: Fix live profiling error tests#151020

Merged
encukou merged 1 commit into
python:mainfrom
pablogsal:gx-xxxx
Jun 17, 2026
Merged

gh-150966: Fix live profiling error tests#151020
encukou merged 1 commit into
python:mainfrom
pablogsal:gx-xxxx

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 6, 2026

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 6, 2026
@pablogsal pablogsal added needs backport to 3.15 pre-release feature fixes, bugs and security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jun 6, 2026
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 9ed3399 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151020%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2026
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2026
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 585fdce 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151020%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2026

@lkollar lkollar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This change fix #150966 issue for me.

I can no longer reproduce the issue using ./python -m test test_profiling.test_sampling_profiler.test_live_collector_ui -m test_run_failed_module_live -m test_run_failed_script_live -u all -F -j40.

@vstinner

Copy link
Copy Markdown
Member

"buildbot/ARM64 macOS PR" failed

It failed because of an unrelated issue, test_ssl failed with a timeout on ssl connect_ex().

test_connect_ex_error (test.test_ssl.BasicSocketTests.test_connect_ex_error) ...

Timeout (0:20:00)!
Thread 0x0000000206e4ec40 (most recent call first):
  File "/Users/buildbot/buildarea/pull_request.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1443 in _real_connect
  File "/Users/buildbot/buildarea/pull_request.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1464 in connect_ex
  File "/Users/buildbot/buildarea/pull_request.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 971 in test_connect_ex_error

...
3 re-run tests:
    test.test_asyncio.test_sock_lowlevel test_socket test_ssl
1 test failed:
    test_ssl

@encukou encukou merged commit 6b142ab into python:main Jun 17, 2026
152 of 153 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @pablogsal for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 17, 2026

Copy link
Copy Markdown

GH-151604 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 17, 2026
vstinner pushed a commit that referenced this pull request Jun 17, 2026
gh-150966: Fix live profiling error tests (GH-151020)
(cherry picked from commit 6b142ab)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants