gh-150258: Show relative percentage on Tachyon flamegraph#150266
Conversation
When running profiling, users rarely care about the global percentage of the runtime. Often, they want to select a function and measure child percentages relative to that. This PR updates the flamegraph tooltips to show both "Percentage" and "Relative Percentage" when the user clicks a specific function. Fixes python#150258
…lme/cpython into tachyon-relative-percentage
scottshambaugh
left a comment
There was a problem hiding this comment.
Tested locally and this matches what I was looking for in the issue, thanks for putting this together!
Thx for all the feedback! Glad it matches what you were looking for. I also think this will be useful! :) |
|
Thanks @edvilme for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-150312 is a backport of this pull request to the 3.15 branch. |
…150266) (#150312) gh-150258: Show relative percentage on Tachyon flamegraph (GH-150266) When running profiling, users rarely care about the global percentage of the runtime. Often, they want to select a function and measure child percentages relative to that. This PR updates the flamegraph tooltips to show both "Percentage" and "Relative Percentage" when the user clicks a specific function. (cherry picked from commit fad0674) Co-authored-by: Eduardo Villalpando Mello <eduardovil@microsoft.com>
|
When running profiling, users rarely care about the global percentage of the runtime. Often, they want to select a function and measure child percentages relative to that.
This PR updates the flamegraph tooltips to show both "Percentage" and "Relative Percentage" when the user clicks a specific function.
Fixes #150258
Visualization
With no functions selected

With a function selected

Remarks
"Relative percentage" is only shown for the children of the selected node (<100%)