Skip to content

gh-64551: Add RFC 5034 AUTH support to poplib#142613

Open
fatelei wants to merge 8 commits into
python:mainfrom
fatelei:poplib_auth
Open

gh-64551: Add RFC 5034 AUTH support to poplib#142613
fatelei wants to merge 8 commits into
python:mainfrom
fatelei:poplib_auth

Conversation

@fatelei

@fatelei fatelei commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Add RFC 5034 AUTH support to poplib


📚 Documentation preview 📚: https://cpython-previews--142613.org.readthedocs.build/

@diegorusso

Copy link
Copy Markdown
Contributor

Can you please rebase/merge your branch on top of main please?

@fatelei

fatelei commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

Can you please rebase/merge your branch on top of main please?

done

@diegorusso

Copy link
Copy Markdown
Contributor

Can you please rebase/merge your branch on top of main please?

done

Thanks! I removed all the reviewers and added only the ones in the original issue.

Comment thread Lib/poplib.py Outdated
@picnixz picnixz self-requested a review December 12, 2025 13:12

@bitdancer bitdancer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I have several suggestions, mostly about mimicing the smtplib API for consistency.

Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py Outdated
@bedevere-app

bedevere-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aisk

aisk commented Dec 25, 2025

Copy link
Copy Markdown
Member

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

@fatelei

fatelei commented Dec 25, 2025

Copy link
Copy Markdown
Contributor Author

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

i rebase, but i can not push, so i force push, sorry

@aisk

aisk commented Dec 25, 2025

Copy link
Copy Markdown
Member

i rebase, but i can not push, so i force push, sorry

You can fetch the remote, then use git merge ... to merge the changes into your local branch, make further changes, and finally git push ... to the remote safely and without -f option.

Comment thread Lib/poplib.py Outdated
Comment thread Doc/library/poplib.rst Outdated
Comment thread Doc/library/poplib.rst Outdated
Comment thread Doc/library/poplib.rst Outdated
Comment thread Lib/poplib.py
Comment thread Lib/poplib.py Outdated
Comment thread Lib/poplib.py
Comment thread Lib/poplib.py Outdated
Comment thread Lib/test/test_poplib.py
Comment thread Misc/NEWS.d/next/Library/2025-12-12-15-09-34.gh-issue-64551.NfWlQX.rst Outdated
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants