Repository navigation
Conversation
Vansh8803
force-pushed
the
fix/reject-non-ascii-digits-in-numbers
branch
from
October 25, 2026 17:22
a0ff01c to
af21469
Compare
Contributor
|
Explain why not #676 |
Author
Thanks, I hadn't seen #676. It predates this and is more complete: it also rejects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tomlkit accepts non-ASCII Unicode digits in numbers because
int()andfloat()convert them. A token like1followed by U+0660 (Arabic-Indic digit zero) parses to10instead of being rejected, so an invalid document is read as a valid one with the wrong value. This requires the cleaned numeric token to be ASCII before conversion, raisingInvalidNumberErrorotherwise. Adds a regression test; existing tests still pass.