Repository navigation
Fix appends after standalone array comments - #680
Open
KennyMcSimpson wants to merge 2 commits into
Open
KennyMcSimpson wants to merge 2 commits into
KennyMcSimpson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Appending to
x = [1\n# note\n]produces invalid TOML: the new value is written after the comment without a separator after1. This affectsappend,extend, and insertion beyond the end when the final value has no trailing comma.Use the index map to find the preceding actual value when adding its missing comma. Keep the existing formatting group for indentation, so standalone comments and array layout are preserved. Add regressions for all three operations, consecutive comments and existing-comma controls, plus a changelog entry. This is separate from #666, which only optimizes index rebuilding.
Validation: the added regressions produce six failures and six passing controls on unchanged master. The complete suite passes on Python 3.13 (1,215 tests) and Python 3.10 (1,214 passed, one skipped), including the pinned toml-test corpus. All pre-commit hooks pass. Independent checks with stdlib
tomllibalso pass. Strict mypy reports the same six pre-existing errors on both unchanged source and this patch; none are introduced in the changed lines.Agent Drafting Metadata