Integration tests improvements#306
Conversation
|
@JeanLucPons, @TeresiaOlsson, @gubaidulinvadim, @kparasch, @simoneliuzzo, @ everybody... Feel free to contribute directly to the branch if you want, preferably in separate files. I can also build a lightweight configuration if needed. |
|
@gupichon I can have a look, but I prefer to do it after the latest changes on the twin side from Waheed are included. |
I agree, but it would help me if I had a concrete idea of the tests to be implemented. |
|
I'm wondering if we should turn everything we have in examples to integration tests instead? We needed the examples for the last workshop but they are starting to feel more and more difficult to maintain since they are not included in the tests. Maybe now they would be better as integration tests instead? Especially since I'm working on making a separate repository for documentation which should include tutorials and then the purpose the examples had will be covered by those instead. |
For now, I'm mainly experimenting with the twin. As for the examples, they are just loaded, nothing is executed. They should be removed if the examples are moved to another repository. The idea here is that as long as they are inside the pyaml repository, a test should check if they are still valid. |
This is mostly the configuration file changes that have broken the examples recently. Everything else is mostly intact and/or very easy and quick to fix. |
|
My prefix in controls:
- type: pyaml_cs_oa.controlsystem
name: live
prefix: //ubuntu24acu.esrf.fr:30000/
catalog: fodo_1gev_6d_pyaml_catalogs-oa.yaml |
|
@JeanLucPons, attention: TRM will not work in the present twin version; there's a bug. The rest should be fine. |
|
Hello @gubaidulinvadim, @TeresiaOlsson, @JeanLucPons, and all. I have updated the twin and merged it with the main branch. As the twin project has been significantly updated on Soleil's end, I would recommend merging this PR as soon as possible. |
|
It looks good, but I can only review properly next week when you're on vacation @gupichon :) |


Summary
This PR updates the DT4ACC integration setup to use the new public
dt4acc-soleil-twinimage and the updated embedded Tango launcher interface.It also replaces the previous single-file FODO test configuration with a dedicated FODO 1 GeV 6D integration dataset, including the DT4ACC accelerator setup, lattice, pyAML device configuration, Tango catalog, and pyaml-cs-oa catalog.
Changes
oras://registry.synchrotron-soleil.fr/software_control_system_public/dt4acc-soleil-twin:latesttango-db-embeddedcommand.ophyd-async[tango, ca, pva]for integration coverage.tango-pyamlandpyaml-cs-oabackends against the same twin.Accelerator.from_dictdocstring parameter type.